search

AAHB / mathdoku

Automatically exported from code.google.com/p/mathdoku
0 stars 0 forks source link

Numbers on button green for Maybe #42

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1. Enhancement
2.
3.

What is the expected output? What do you see instead?

What version of the product are you using? On what operating system?
Android

Please provide any additional information below.

To reduce frustration when mistakenly hitting a number button when you thought 
Maybe check was activated, change numbers on buttons from black to green in 
color like Maybe check's color when Maybe is activated.

Original issue reported on code.google.com by iowah...@gmail.com on 6 Jul 2012 at 8:38

GoogleCodeExporter commented 8 years ago 
Or change select cell color from yellow to green when Maybe is checked

Original comment by iowah...@gmail.com on 9 Jul 2012 at 2:27

GoogleCodeExporter commented 8 years ago

Original comment by paul.din...@gmail.com on 15 Mar 2013 at 4:00

GoogleCodeExporter commented 8 years ago 
Solved in revision 139.

Original comment by paul.din...@gmail.com on 21 Mar 2013 at 10:06

GoogleCodeExporter commented 8 years ago

Original comment by paul.din...@gmail.com on 21 Mar 2013 at 10:16

Attachments:

GoogleCodeExporter commented 8 years ago 
From: Paul Dingemans
Sent: 21 March 2013 22:13
To: Pimm Hogeling
Cc: Ben Buxton; Pimm Hogeling; Stephen Lee; Anthony Paul; Alexander
Tesfamichael
Subject: MathDoku: numbers on button turn green in case of maybe

Pimm,

Please check revision 135 which solves issue 42. Although this change is
succesfully implemented, I have some doubt whether we should do this from a
UI perspective.

Please advise.

Paul

Original comment by paul.din...@gmail.com on 23 Mar 2013 at 1:54

GoogleCodeExporter commented 8 years ago 
On 22-3-2013 9:19, Stephen Lee wrote:
> I'd just like to add my opinion as a "user":
>
> When I read this email, I didn't think I'd like it, but after playing a few
> games, personally I think it's a good feature.
>
> It gives a visual cue about which "maybe mode" (on/off) I am in, without
> having to look at the check box.
> Furthermore, it's noticeable when it automatically switches (I never noticed
> the checkbox going on automatically).
>
> So it gets a thumbs up from me (although I'm not sure if green is the best
> colour - UI design is not my strong point either).
>
> Regards
> Stephen

Original comment by paul.din...@gmail.com on 23 Mar 2013 at 1:55

GoogleCodeExporter commented 8 years ago 
On 22-3-2013 16:24, Pimm Hogeling wrote:
> Thanks for the ping, Paul. (Feel free to copy the contents of this email to 
code.google.com.)
>
> Remember when I said "the maybe checkbox, […] is mode error waiting to 
happen"? i42 describes what I meant exactly.
>
> I think changing the appearance of the digit buttons is an improvement from 
an Interface Designer's perspective (though I don't like the way it looks).
>
> The digit buttons behave either one of two ways, based on the state of a 
check box. The behaviour is visualised by the check box. The problem is that 
the check box is very likely not within the locus of the user. Therefore, the 
user might wrongly expect the digit buttons to behave in a certain way.
>
> With r139, the behaviour of the digit buttons is also visualised by the digit 
buttons, which are more likely to be in the locus of the user. This reduces the 
chance of a mode error.
>
> (Alexander and) I would like to propose three other solutions that would 
solve the problem more gracefully, without overthrowing the entire interface. 
(They are sorted from least to most drastic in terms of changing the existing 
interface.)
>
> Board Visualisation
> Rather than visualising the behaviour of the digit buttons in the digit 
buttons, visualise it in the board. The board is the one thing that will always 
be in the user's locus. Highlight either the regular digits or the maybes, 
based on the current behaviour.
>
> Label-style
> Remove the maybe check box altogether, instead turn the digit buttons into 
togglers. When the user clicks a digit button, it appears in a special list of 
selected digits. More than one selected digit per cell indicates doubt, and is 
visualised in the board as maybes. Clicking a selected digit deselects it.
> Detail: the selected digits appear chronologically. The last digit the user 
has selected is at the bottom of the list. This additional control will give 
pro players like yourselves some extra note-taking power.
>
> Side slider
> Selecting maybes is done by clicking entirely different buttons from the 
regular digit buttons. They slide in from the side by clicking a button, or the 
associated gesture.
>
> Let me know what you guys think. Much love ♥!
>
> A quick note:
> It's great to listen to users. Just remember: most MathDoku players are not 
Interface Designers. And besides that, the amount of MathDoku experience the 
people in the to-line of this email have is greater than that of the average 
player.
> More often than not, you guys (or 'we') will have a better understanding of 
what the interface should be like than some user. If a user suggests something, 
don't implement it to please him/her. If you know it's a bad idea, don't even 
make it an option. Don't give the cat a proboscis. Leave that shit out.

Original comment by paul.din...@gmail.com on 23 Mar 2013 at 1:56

GoogleCodeExporter commented 8 years ago 
On 23-3-2013 11:54, Paul Dingemans wrote:
> Hi Pimm,
>
> Sorry that I addressed you as a guy before. I really had not the faintest 
idea that you are female. But as you wrote you are still part of the team and 
therefore one of the guys :P
>
> I have had some deep thought on your email yesterday. It took me quite some 
brainpower to actually understand what you meant. When I woke up this morning 
it was clear to me what to do.  My thoughts about the proposals were:
>
> Board Visualisation
> Easy to realise.
>
> Label-style
> I do understand the idea of list of selected maybes in chronological order. I 
have never wanted such functionality myself. I see following disadvantages:
> * You need an option whether you want to order the selected maybes or not 
because you have to look careful at this list in case you want to remove a 
value.
> * How would this be visualized with on a 9x9 board?
> * How does this solution fit into the bigger UI-picture we are planning for 
in Milestone 2.0?
>
> Side slider
> I do understand the idea of having different buttons for definitive values 
versus possible values. Like the label-style solution it will be difficult to 
find enough space for those extra buttons. Once again I don't see how this will 
fit into the UI 2.0.
>
>
> Based on thoughts above I have implemented the Board Visualisation proposal 
with following changes:
> * In normal input mode the definitive values, the number buttons, and the 
mode label all have the same color associated with entering definitive values. 
The maybe values are in this mode displayed in a normal base color.
> In maybe mode the definitive values will be displayed in the base color while 
all maybe values, the number button and the mode label are displayed in the 
color associated with the maybe values.
> * The maybe checkbox has disappeared. We now have simply a label which tells 
us in which mode we are working currently.
> * The mode label can be touched to toggle the input mode. Also when the 
selected cell is touched once again, the input mode is toggled.
>
> See examples attached (based on my local development environment). I will 
commit this code later today after I have done some clean up. Of course it took 
a little bit more effort than expected ...
>
> The appearance of definitive values, number button and mode label can be 
easily changed in the painter class. Can you advise on which colors (per theme) 
to use?
>
> Paul

Original comment by paul.din...@gmail.com on 23 Mar 2013 at 1:56

GoogleCodeExporter commented 8 years ago 
See revision148 for Board Visualisation implementation.

Original comment by paul.din...@gmail.com on 23 Mar 2013 at 2:04

GoogleCodeExporter commented 8 years ago 
Tested on Revision 163: Colour changes now make it more obvious whether you are 
entering maybe or actual cell values.

Original comment by em...@srlee.com on 27 Mar 2013 at 1:44