AAPS-Omnipod / AndroidAPS

GNU Affero General Public License v3.0
21 stars 19 forks source link

Support Temporary Basal Rates with percentage values #10

Closed samspycher closed 4 years ago

samspycher commented 4 years ago

Setting a TBR with a percentage value results in this log message:

09:16:57.440 [Thread-4823] D/PUMP: [OmnipodPumpPlugin.setTempBasalPercent():902]: setTempBasalPercent [OmnipodPumpPlugin] - Not implemented.

This can be reproduced with two phones, where the non-AAPS phone sends the following command to the AAPS phone via SMS message:

  1. Install & configure AAPS, and set up remote SMS commands as described here
  2. Send e.g. the SMS BASAL 105% 10 from non-AAPS to AAPS phone
  3. After receiving response from AAPS phone, enter Authenticator Key and Secret
  4. Wait for response message indicating failure
  5. Verify missing feature in log at time of SMS exchange.

Example exchange:

WhatsApp Image 2020-10-02 at 09 17 26
bartsopers commented 4 years ago

Fixed by @samspycher