search

AAPS-Omnipod / AndroidAPS

GNU Affero General Public License v3.0
21 stars 19 forks source link

Pod info response type 2 is decoded incorrectly #8

Closed bartsopers closed 3 years ago

bartsopers commented 3 years ago

See FIXME in PodInfoFaultEvent:

// FIXME below line DOES NOT MATCH the OpenOmni Wiki description of the type 2 pod info response
// See https://github.com/openaps/openomni/wiki/Command-02-Pod-Information-Response#type-2
// Example of an observed message from the Pod that makes below line throw an IllegalArgumentException:
// 1F0F038F20180216020D00000000000012FFFF03FF00160000879A070000012E
// the LogEventErrorCode class doesn't make any sense and should be removed. Instead, the a, bb and c bits in byte 17
// should be decoded independently as per the response description on the OpenOmni Wiki
logEventErrorType = LogEventErrorCode.fromByte(value);
bartsopers commented 3 years ago

This has recently been fixed