search

AAROC / DevOps

DevOps code to deploy eScience services
http://www.africa-grid.org/DevOps
Other
19 stars 40 forks source link

UNN IdP in group_vars #350

Open cudanor opened 7 years ago

cudanor commented 7 years ago

I have created a new file under group_vars for the University of Nigeria IdP called unn_idp. Please kindly review my entries to see if they are alright. Thanks

cudanor commented 7 years ago

Hi Bruce, Thanks for your support, but I do not understand what to do with this piece since I cannot find it in the original doc.

In Ansible/site.yml https://github.com/AAROC/DevOps/pull/350#pullrequestreview-16102878:

@@ -19,10 +19,10 @@ slack:

Revert the changes in this file - they are incorrect.

Besides also, I can no longer find the file unn_idp in group_vars. Do I have to recreate it?

Thanks

On Thu, Jan 12, 2017 at 4:04 PM, Bruce Becker notifications@github.com wrote:

@brucellino requested changes on this pull request.

Hi @cudanor https://github.com/cudanor thanks for fixing the site.yml - just need to take care of the other two issues.

In Ansible/group_vars/unn_idp https://github.com/AAROC/DevOps/pull/350#pullrequestreview-16102878:

@@ -0,0 +1,34 @@ +# institute metadata +site_name: UNN IdP +host_institute:

  • name: University of Nigeria
  • url: http://www.unn.edu.ng

  • +# LDAP variables +server_country: NG +server_state: +server_location: Nsukka +server_organization: NGREN +server_organization_unit: UNN +ldap_server: ldap.grid.unn.edu.ng +root_password_clear: HiPIC#17

Move this variable (and all others) to passwords-{{ site_name }}.yml (e.g. passwords-unn.yml). This is pulled in dynamically by the playbook. You should encrypt those passwords with ansible-vault, or leave them out of the repo entirely.

In Ansible/group_vars/unn_idp https://github.com/AAROC/DevOps/pull/350#pullrequestreview-16102878:

@@ -0,0 +1,34 @@ +# institute metadata +site_name: UNN IdP

The name should not have spaces. Also, it should refer to the site (UNN), not a specific service (IdP). I would change this to lower-case : site_name: unn

In Ansible/site.yml https://github.com/AAROC/DevOps/pull/350#pullrequestreview-16102878:

@@ -19,10 +19,10 @@ slack:

Revert the changes in this file - they are incorrect.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/AAROC/DevOps/pull/350#pullrequestreview-16102878, or mute the thread https://github.com/notifications/unsubscribe-auth/AGoKwiHkX1ngCH3ZBSEqJjVtLuJxuVc4ks5rRkDtgaJpZM4LgANr .