AASJournals / AASTeX60

Version 6 of the LaTeX style files and documentation for authoring AAS Journal (AJ/ApJ) articles.
https://journals.aas.org/aastex-package-for-manuscript-preparation/
LaTeX Project Public License v1.3c
46 stars 26 forks source link

Bug? in Acknowledgments #102

Open MarkDurre opened 4 years ago

MarkDurre commented 4 years ago

If the \acknowledgements section is not terminated with 2 line breaks, it causes an error on compilation "You can't use `\end' in internal vertical mode."

gregschwarz commented 4 years ago

Which version, v6.3?

MarkDurre commented 4 years ago

Yes, 6.3 – it works fine on 6.2

Dr. Mark Durré Centre for Astrophysics and Supercomputing Swinburne University of Technology PO Box 218, Hawthorn Victoria 3122, Australia Email: mdurre@swin.edu.aumailto:mdurre@swin.edu.au

From: gregschwarz notifications@github.com Sent: Sunday, 8 December 2019 12:11 AM To: AASJournals/AASTeX60 AASTeX60@noreply.github.com Cc: Mark Durre mdurre@swin.edu.au; Author author@noreply.github.com Subject: Re: [AASJournals/AASTeX60] Bug? in Acknowledgments (#102)

Which version, v6.3?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/AASJournals/AASTeX60/issues/102?email_source=notifications&email_token=AC74ZCFIVGUV3BAAFE55F5TQXOOHRA5CNFSM4JXKF7Z2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGGGSUA#issuecomment-562850128, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AC74ZCFCBSCDIKMXMOS5F3LQXOOHRANCNFSM4JXKF7ZQ.

augustfly commented 4 years ago

Hi Mark,

I'm having trouble reproducing your bug report. Could you please provide a minimum working(or rather "not working) example?

Thank you,

MarkDurre commented 4 years ago

Hi Gus,

Please find attached examples, plus log files. The only difference between them is the line space after the acknowledgement text.

Cheers,

Dr. Mark Durré Centre for Astrophysics and Supercomputing Swinburne University of Technology PO Box 218, Hawthorn Victoria 3122, Australia Email: mdurre@swin.edu.aumailto:mdurre@swin.edu.au

From: August Muench notifications@github.com Sent: Sunday, 8 December 2019 12:35 AM To: AASJournals/AASTeX60 AASTeX60@noreply.github.com Cc: Mark Durre mdurre@swin.edu.au; Author author@noreply.github.com Subject: Re: [AASJournals/AASTeX60] Bug? in Acknowledgments (#102)

Hi Mark,

I'm having trouble reproducing your bug report. Could you please provide a minimum working(or rather "not working) example?

Thank you,

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/AASJournals/AASTeX60/issues/102?email_source=notifications&email_token=AC74ZCDKIVXCZLZC6GMNUILQXOQ7FA5CNFSM4JXKF7Z2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGGG7JI#issuecomment-562851749, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AC74ZCGKYUQ6JWDFCT4OGELQXOQ7FANCNFSM4JXKF7ZQ.

augustfly commented 4 years ago

Hi Mark,

Your email reply to this thread passes first through GitHub, which strips attachments to emails. Can you send the examples to me at journals.support@aas.org?

thanks,

gus

augustfly commented 4 years ago

Thanks @MarkDurre for the MWE.

\documentclass[]{aastex63}                                                                
\begin{document}
Some document contents
\acknowledgments
Some acknowledgements.
\end{document}

The error must be in the definition of the the "x" and "y" acknowledgement blocks and the subsequent "checkforblankline" that toggles between these two blocks. See

https://github.com/AASJournals/AASTeX60/blob/master/cls/aastex63.cls#L1205-L1228

Once again I suspect that this is another anonymous coding bug since those section worked in 6.2 but the addition of the anonymous code broke it. So I think this is in fact related to #100 .

augustfly commented 4 years ago

I believe this bug can also cause linebreaks to float into the references producing undesired formatting. The only work around I know is to put the entire acknowledgement block into {} brackets.

Reported: https://twitter.com/Astro_Wright/status/1263144211949539332

Note also that revtex 4.1 issues a warning we might not be taking serious enough, especially with how we are implementing anonymous:

Class revtex4-1 Warning: Environment acknowledgements is obsolete; Use acknowledgments instead.