search

AAVLD-USAHA-ITStandards / eCVI

eCVI Data Exchange Standard (Starting with version 2)
12 stars 9 forks source link

Address vs. Address Block #35

Closed mkm1879 closed 5 years ago

mkm1879 commented 5 years ago

Having two different formats is causing more problems than it is solving. While the address of consignor, consignee, shipper, and veterinarian are not the key physical addresses, it is still easier to deal with one format rather than two.

alexturnerdvm commented 5 years ago

I think that all address blocks should be identical to the "separated" version that we currently have for the animal location, so that each of these blocks will send the information in a similar format rather than a single text block.

Deevet84 commented 5 years ago

This issue needs to be expedited quicker than the normal schema working group process please. It needs to just be corrected as we discussed and outlined above as a "fix" to the new eCVI v2 schema code rather than getting NASAHO approval as a new idea. It is affecting USA Herds users every day. Thanks.

mkm1879 commented 5 years ago

I have made the suggested change and pushed to the pendingChanges branch. Please evaluate.

Personally, I have software in Alpha test stage. Doing this sooner will be much better for me than doing it later, but my needs are trivial.

Deevet84 commented 5 years ago

What is a pending changes branch?

mkm1879 commented 5 years ago

The official release in the "master" branch hasn't changed but I wanted folks to be able to look at changes I suggest we make. Those are in pendingChanges. See the Branch button at the top of the Code tab in GitHub.

SusanCulp commented 5 years ago

https://github.com/AAVLD-USAHA-ITStandards/eCVI/tree/pendingChanges

Susan Culp, DVM Veterinarian Institute for Infectious Animal Diseases (IIAD) A Member of the Texas A&M University System

1500 Research Parkway, Suite B270 College Station, TX 77843-2129 Office 979.458.2375 | Fax 979.845.6574 iiad.tamu.eduhttp://iiad.tamu.edu | @IIADnews TEXAS A&M UNIVERSITY | FEARLESS on Every Front

From: Deevet84 notifications@github.com Reply-To: AAVLD-USAHA-ITStandards/eCVI reply@reply.github.com Date: Wednesday, March 13, 2019 at 2:38 PM To: AAVLD-USAHA-ITStandards/eCVI eCVI@noreply.github.com Cc: Susan Culp Susan.Culp@ag.tamu.edu, Manual manual@noreply.github.com Subject: Re: [AAVLD-USAHA-ITStandards/eCVI] Address vs. Address Block (#35)

What is a pending changes branch?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_AAVLD-2DUSAHA-2DITStandards_eCVI_issues_35-23issuecomment-2D472574516&d=DwMCaQ&c=r_tSStIHV2ie60z4DgB-pQ&r=vj0_4RfYB0tqxFJSBs4pOLcX71QTh3lwk0cyW6m80Ow&m=HpnnypmySzIY3eKfpWCBSnObdnAo4uIAJJse0NVmVKk&s=8xY52NqeUumLjLikpVm8kvKJ_GmcGNS5opbP_2jBUNE&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AszHRg-5FvSOuccuAnBTDBdXuZ6x551Olfks5vWVOigaJpZM4bhcpD&d=DwMCaQ&c=r_tSStIHV2ie60z4DgB-pQ&r=vj0_4RfYB0tqxFJSBs4pOLcX71QTh3lwk0cyW6m80Ow&m=HpnnypmySzIY3eKfpWCBSnObdnAo4uIAJJse0NVmVKk&s=m-aQvLi2jgrXa0V8MtuIVagZBnk0cFA5tQ69JTVcC8k&e=.

mmcgrath commented 5 years ago

I am happy with the proposed change - we can accommodate the change with a week's notice of it being adopted by those generating/sending eCVIs.

mkm1879 commented 5 years ago

Implementation complete in v2.1