search

AAVLD-USAHA-ITStandards / eCVI

eCVI Data Exchange Standard (Starting with version 2)
12 stars 9 forks source link

[v3.0] Issue with validating InternationalAIN #91

Open MichaelJRussell opened 7 months ago

MichaelJRussell commented 7 months ago

I found an issue with our handling of the new support for international AINs, and while testing that, I found that all CVIs using the InternationalAIN element are being flagged as invalid. The issue seems to be with this block defining the allowed tag elements, it's missing the InternationalAIN option, so no CVIs with that element will be considered valid: https://github.com/AAVLD-USAHA-ITStandards/eCVI/blob/66841820b78bb1b94b11a5326dec5d155c3064b3/ecvi2.xsd#L1039-L1049

Am I missing something? This seems like a major blocker to implementing v3 unless/until that gets resolved.

Edit: I generated an example CVI using fake data to demonstrate the issue: https://gist.github.com/MichaelJRussell/0ebd2c8227c9dbd358b756312be4972b

MichaelJRussell commented 7 months ago

I'm unclear on what the process is for making changes to the standard for fixing issues outside of the normal release cadence, but I went ahead and opened up a pull request for discussion / consideration to implement the change needed to use InternationalAIN as a valid animal tag: https://github.com/AAVLD-USAHA-ITStandards/eCVI/pull/92