Issue #224 fix: getObservationRetriever() returns null if parameter dialog is canceled (if present) that is, in fact, equivalent to CancellationException #225
With this fix, cancellation of the Parameters dialog (if present) in getObservationRetriever() is equivalent to throw CancellationException. This exception currently cannot be thrown from within getObservationRetriever() (we need to add throws to the declaration of the base class too, however with this fix it is not needed)
Now the observation source plug-ins behave consistently (like New Star from AAVSO database plug-in): when dialog is canceled, the toolbar buttons get active (along with menu items). However, they are activated in any case, even if no observations are loaded!
Note: This bug existed before this fix and is not related to it directly: the logic of enabling/disabling the interface elements has issues (probably, a new issue should be created).
With this fix, cancellation of the Parameters dialog (if present) in getObservationRetriever() is equivalent to throw CancellationException. This exception currently cannot be thrown from within getObservationRetriever() (we need to add throws to the declaration of the base class too, however with this fix it is not needed)
Now the observation source plug-ins behave consistently (like New Star from AAVSO database plug-in): when dialog is canceled, the toolbar buttons get active (along with menu items). However, they are activated in any case, even if no observations are loaded! Note: This bug existed before this fix and is not related to it directly: the logic of enabling/disabling the interface elements has issues (probably, a new issue should be created).