search

AAVSO / VStar

VStar is a visualisation and analysis tool for variable star data brought to you by AAVSO
https://www.aavso.org/vstar
GNU Affero General Public License v3.0
9 stars 3 forks source link

Fix unit tests for Java versions > 8 #236

Closed dbenn closed 2 years ago

dbenn commented 2 years ago

There has apparently been a regression on master since all VStar UTs > Java version 8 are failing.

There's also an issue with the Ant UT target in the presence of an Eclipse build that attempts to run additional tests in the build directory.

dbenn commented 2 years ago

See also #229

dbenn commented 2 years ago

All VeLa unit tests are now passing except for the locales "nn" (Norwegian Nynorsk) and "ar_JO" (Arabic Jordan) for which testNegExponent() fails.

We could open an issue to address these as a background task or investigate further now. There are plenty of other issues to work on so spending undue time on this right now may not be prudent. Thoughts @mpyat2?

mpyat2 commented 2 years ago

All VeLa unit tests are now passing except for the locales "nn" (Norwegian Nynorsk) and "ar_JO" (Arabic Jordan) for which testNegExponent() fails.

We could open an issue to address these as a background task or investigate further now. There are plenty of other issues to work on so spending undue time on this right now may not be prudent. Thoughts @mpyat2?

I agree. Sorry for the late answer, I missed this.

mpyat2 commented 2 years ago

@dbenn , Norwegian Nynorsk case can be easily fixed: they use U+2212 (−) instead of a hyphen. This case can be easily fixed by adding a line

dfs.setMinusSign('-');

into ExpressionVisitor.ParseDouble().

ar_JO case is more complicated and can be investigated later.

dbenn commented 2 years ago

Awesome. Thanks Max. I've committed a fix for this.

mpyat2 commented 2 years ago

@dbenn , thank you!