search

AAVSO / VStar

VStar is a visualisation and analysis tool for variable star data brought to you by AAVSO
https://www.aavso.org/vstar
GNU Affero General Public License v3.0
9 stars 3 forks source link

246 B-V observation source plugin creates observations with no names #247

Closed dbenn closed 2 years ago

dbenn commented 2 years ago

Well, this turned out to be bigger than Ben Hur. The name is being set now for B-V observations. In addition, the mag uncertainty is now being computed and set. Finally, a test method was added for the plugin, something I plan to do when the opportunity arises because the test coverage for plugins is low.

@mpyat2, if you are happy to review this, that would be great.

mpyat2 commented 2 years ago

Hi @dbenn , I propose adding the following line (marked yellow): image

Initially, bvOb.getJDflavour() == JDflavour.UNKNOWN. For UNKNOWN values, AbstractObservationRetriever.categoriseValidObservation() sets observation's jDflavour to the ObjervationRetriever default value that is JD by default.

We can assume that the time mode for both B and V bands is the same and take JDflavour from V observations.

dbenn commented 2 years ago

Absolutely @mpyat2. Like it. Thanks. See commit.

mpyat2 commented 2 years ago

Thanks David!