search

AAVSO / VStar

VStar is a visualisation and analysis tool for variable star data brought to you by AAVSO
https://www.aavso.org/vstar
GNU Affero General Public License v3.0
10 stars 3 forks source link

#261: fixed bug in which we were advancing too far, skipping a pair, … #263

Closed dbenn closed 2 years ago

dbenn commented 2 years ago

…when a B,V pair were not within time tolerance

Please review the code and solution, thanks Max.

Plugin test still passes with the change and this seems to fix the bug reported.

dbenn commented 2 years ago

Thank you, @david, it works now as expected so I approve it. However, as I see it, the approach used in this plug-in implies that there are close B, V pairs separated by long intervals. There are, however, time series where B, V observations are almost equidistant on both sides (imagine that someone makes alternated B, V observations with filter wheel). In this case the simplest linear interpolation between adjacent points would make sense. Also, in the future, we could think about generalizing the plugin to an arbitrary pair of filters.

Thanks and agreed @mpyat2. I've created #264 for the second issue which I've been meaning to for awhile. Would you like to create an issue for the interpolation aspect?