search

AAVSO / VStar

VStar is a visualisation and analysis tool for variable star data brought to you by AAVSO
https://www.aavso.org/vstar
GNU Affero General Public License v3.0
10 stars 3 forks source link

make plugin ant clean works on Windows #318

Closed orionlee closed 1 year ago

orionlee commented 1 year ago

The current plugin ant clean does not work on Windows, when it tries to deleting src/**/*.class:

BUILD FAILED
c:\dev\VStar\plugin\build.xml:276: java.nio.file.InvalidPathException: Illegal char <*> at index 24: c:\dev\VStar\plugin\src\**\*.class
        at java.base/sun.nio.fs.WindowsPathParser.normalize(WindowsPathParser.java:182)
...

This PR fixed it.

I wonder, however, whether deleting src/**/*.class is still needed. On my build, there is no .class generated in src. directory. Is it needed for, say, Eclipse build? Or is it some legacy logic that can be removed?