mpyat2
commented
1 year ago Hi @dbenn , I made fixes according to your remarks and also fixed (I hope) dependent lib ref counting plus MessageBoxes calling via InvokeLater (they always recommend not to call interface-related methods in the background thread, I wonder why we still have not had any problems with this. Maybe MessageBoxes is something special). I also added Cliff to the reviewers because I made severe changes to his work. Well, there was too much side work with the PluginManager here, I should stop it and create a ticket if something more is required. Let's see.
Hi @dbenn , Here are severely reworked GAIADR2XformObSource (retrieving Gaia data from the Internet) and the new GAIADR2XformFileObSource, which reads from a local file. Both extend the base class GaiaObSourceBase, which is moved to a separate shared jar, placed in vstar_plugin_libs. PluginManager refused to work with them (it could not create an instance of the Gaia class because it did not retrieve the shared jar from a remote location). So I fixed the PluginManager too. I also made some additional PluginManager fixes and refactoring. Although it was not directly related to the Gaia plug-ins, as far as the PluginManager needed to be fixed anyway, I decided to make more fixes. One important fix was the new areURLReferentsEqual() method. The old one ALWAYS gave FALSE. The new one, I hope, works correctly.