search

AAVSO / VStar

VStar is a visualisation and analysis tool for variable star data brought to you by AAVSO
https://www.aavso.org/vstar
GNU Affero General Public License v3.0
9 stars 3 forks source link

Period analysis dialog issues with messages #383

Closed mpyat2 closed 7 months ago

mpyat2 commented 8 months ago

This addresses issues #381, #382, and at least partially #61 (IllegalArgumentException while selecting harmonics in HarmonicInfoDialog).

mpyat2 commented 8 months ago

Hi @dbenn , I know you are busy with Auth0; please review this only when you have time after any urgent things. Probably I will make some additional changes after additional tests, so there is no rush here.

mpyat2 commented 8 months ago

Hi @dbenn ,

Thank you for the suggestions!

The use of the message identifier is entirely optional. It is something like a tag (label) attached to the message. Currently, it is used in the period analysis dialogs only to distinguish between dialog instances that may coexist if the user leaves the previous dialogs open. I practiced this, and as we can see, I'm not unique. Well, 'name' probably is not the best name for the field (ha-ha, the sentence sounds funny). Maybe 'tag' sounds better?

By the way, to get rid of multiple showing the harmonic dialog, I added a secondary identifier (iDstring) to HarmonicSearchResultMessage. Concerning blocking the harmonics dialog on the tabs with tables: I will try to remove this blocking and implement top-hit/data point selection.