search

AAVSO / VStar

VStar is a visualisation and analysis tool for variable star data brought to you by AAVSO
https://www.aavso.org/vstar
GNU Affero General Public License v3.0
9 stars 3 forks source link

Deselecting error bars in Plot Control Dialog only changes current mode #395

Closed dbenn closed 5 months ago

dbenn commented 5 months ago

If the Error Bars? checkbox in the Phase Plot Control dialog is deselected, the error bars in the phase plot disappear, but not so in the Light Curve plot if you switch back to raw mode from phased mode. Yet, open the Light Curve Control dialog and the Error Bars? checkbox is still deselected.

So, one of two things needs to happen:

  1. The Error Bars? checkbox state needs to correctly reflect the current mode's visual plot error bar state, or
  2. the plot of the mode switched to needs to change to match the Error Bars? checkbox state.

My inclination is to go with 1. since the user deselecting errors bar for one plot does not mean they wanted to deselect them for both plots.

dbenn commented 5 months ago

This turns out to apply to all non-series related checkboxes in the Plot Control Dialog (error bars, inverted y axis, joined means, ...)! I've changed the handling of these in the DocumentManager to include analysis type (raw vs phased).

So, currently, plot control checkboxes are sensitive to mode (raw light curve vs phase plot) whereas selected and available series are the same across light curve and phase plot modes.