search

AAVSO / VStar

VStar is a visualisation and analysis tool for variable star data brought to you by AAVSO
https://www.aavso.org/vstar
GNU Affero General Public License v3.0
9 stars 3 forks source link

Load multiple observation files in sequence #398

Closed dbenn closed 5 months ago

dbenn commented 5 months ago

I was recently asked via email by Santana Basu whether it is possible to load multiple Kepler/TESS FITS files.

It is currently not. It should be possible for N files to be loaded as if they were one, assuming they are all of the same type. Otherwise, not since we currently require the user to select the observation source type.

The same is true for any observation source where files are loaded.

It is however also true that unless an observation source plugin is explicitly modified to handle multiple files (streams, by the time the plugin sees them), only the first selected file will be handled.

The core code in NewStarFromObSourcePluginTask and AdditiveLoadFileOrUrlChooser will need to be modified to permit multiple files to be selected, returned, and made available to the plugin.

dbenn commented 5 months ago

The initial request for multiple file loading via the Kepler/TESS (and because of common obs retriever code: QLP and Lightkurve) plugin has been implemented, in addition to the general mechanism by which to enable this in other obs source plugins in future. There may not be time to do more of these before the next release.

dbenn commented 5 months ago

As the last few commits shows, there's some subtlety in the way multiple file selection in the file chooser has to be set depending upon whether the plugin is selected from a list in the File menu vs file chooser and whether the selection there has changed.

dbenn commented 5 months ago

I'm sure there will be the opportunity for further improvements to the approach in future, but it appears to be OK for now.