DownloadFormatObservationSinkPlugin: Problem with "Space" delimiter

[mpyat2]

1. New Star from AAVSO Database..., T Umi, Minimum JD= 2460310.5, Maximum JD= 2460425.5
2. Observations, Save -> Type= "Download", Delimiter= "Space", any name (like T_Umi_space_delim.txt)
3. File Open -> Source="Download or Simple"
4. Select the "Observations" tab and look at the "Name" column: identifiers with spaces truncated.

Possible solution: in ValidObservation.toAAVSOFormatString: use "quoteForCSVifNeeded" for all text fields (not only for comments).

    private String quoteForCSVifNeeded(String field, String delimiter) {
        return field.contains(delimiter) ? quoteForCSV(field) : field;
    }

[dbenn]

Hi @mpyat2, although I agree this is a good idea in principle and has probably been in the code for a long time, I'm having trouble reproducing the error. See this row with spaces in the name for example:

[mpyat2]

Hi @dbenn Could you please attach a file (space-separated) you opened?

[mpyat2]

Here is my example T_Umi_space_delim.txt

And what I see after opening it:

[dbenn]

Hi @dbenn Could you please attach a file (space-separated) you opened?

@mpyat2, here it is; I used the same name for the file :) T_Umi_space_delim.txt.csv

[dbenn]

Interesting that you see this problem and I don't on very similar builds. Windows vs Mac? Unlikely unless we're talking about CR+LF etc. od -c may provide some insights but I don't see anything immediately obvious in the file.

EDIT: see next comment below!

Very happy for you to go with your proposed solution (your code above) if you want to.

[dbenn]

Ah, a key difference is that I saved as CSV and you saved with space delimiters and indeed, you did say to use Delimiter= "Space". So yes, I can see why you see what you do and that quoted strings would help. So, yes, your proposed code change makes sense. Thanks!