search

AAVSO / VStar

VStar is a visualisation and analysis tool for variable star data brought to you by AAVSO
https://www.aavso.org/vstar
GNU Affero General Public License v3.0
9 stars 3 forks source link

Issue 414 FlexibleTextFileFormatObservationSink #417

Closed mpyat2 closed 2 months ago

mpyat2 commented 2 months ago

See #414

mpyat2 commented 2 months ago

Hi @dbenn , please do not close this pull request, I found a small glitch and want to fix it first.

mpyat2 commented 2 months ago

Hi again @dbenn :)

I fixed the glitch, so now the branch is ready for review

mpyat2 commented 2 months ago

Hi @dbenn , thank you for the suggestion! You are right; making ValidObservation.quoteForCSVifNeeded(...) public static allows us to eliminate code duplication. However, now this method is in the parallel universe of the other branch, creating a quantum wormhole between them may lead to something unpredictable (sorry, I'm reading Dan Simmons' Ilium/Olympos cosmic opera now and some nonsense comes into my head :) ). So, it would probably be better to make a new branch after merging this one, and I will refactor the code. What do you think?

dbenn commented 2 months ago

Agreed. That sounds good @mpyat2