Inappropriate use of "Dyadic optimisation error"

AAVSO / VStar

VStar is a visualisation and analysis tool for variable star data brought to you by AAVSO

https://www.aavso.org/vstar

GNU Affero General Public License v3.0

9 stars 3 forks source link

Open dbenn opened 1 week ago

dbenn commented 1 week ago

Code like:

"1" - "2"

should not yield:

Dyadic optimisation error

This error arises in ExpressionVisitor.optimisedDyadicOpAST() (see also ExpressionVisitor.optimisedMonadicOpAST() for a similar error).

It should be reported better.

dbenn commented 1 week ago

VeLaInterpreter.applyBinaryOperation() should explicitly handle all type cases for each operation.