AAndyProgram / SCrawler

πŸ³οΈβ€πŸŒˆ Media downloader from any sites, including Twitter, Reddit, Instagram, Threads, Facebook, OnlyFans, YouTube, Pinterest, PornHub, XHamster, XVIDEOS, ThisVid etc.
https://discord.gg/uFNUXvFFmg
GNU General Public License v3.0
1.29k stars 85 forks source link

[BUG] Imgur Albums on Reddit user page. #100

Closed twosushi closed 1 year ago

twosushi commented 1 year ago

Does not download Imgur albums from a NSFW Reddit user page. Not sure if this is intended behavior.

Steps to reproduce the behavior:

  1. NSFW URL
    https://www.reddit.com/user/Ok_wat/
    
  2. Add link to SCrawler, Use "Download data".
  3. Only downloads some Imgur posts but not the albums.

Please advise, Thanks.

AAndyProgram commented 1 year ago

Confirmed. I need time to figure out what happened. Previously, imgur albums could also be downloaded.

AAndyProgram commented 1 year ago

Fixed. Please update to the latest release.

If you like SCrawler, please like the program on this site: https://alternativeto.net/software/scrawler/about/.

twosushi commented 1 year ago

Sorry to be a bother but it seems for me both SCrawler_2023.1.24.0_x64.zip & SCrawler_2023.1.24.0_x86.zip releases still can't seem to download the Imgur albums.

All I do is download release, extract release, open extracted Scrawler, add link, right click "Download Data". I seem to still only be getting the same 11 images from the link as last time. Or maybe I'm doing something wrong.

Please advise, Thanks again for your time.

AAndyProgram commented 1 year ago

I have completely downloaded the profile you posted. Have you set up an Imgur client ID?

An Imgur client ID is required to download NSFW content. Otherwise, if an image, posted on Reddit as an image (like https://imgur.com/abcde.jpg) will be try to download using the regular algorithm. URLs like https://imgur.com/abcde require an Imgur client ID.

twosushi commented 1 year ago

You are correct. I did not know I needed to add the Imgur Client ID. I have since added it and it has fixed my issue. Thank you very much!

AAndyProgram commented 1 year ago

You are welcome 😊

twosushi commented 1 year ago

Hmm, I have an actual bug this time with some of the Imgur albums still. So it handles the rest fine. But when Imgur URL has one with a "#" symbol in it it seems to not pick it up. Still the same Reddit user link.

For the following posts:

My New [F]ancy Teddy! ;) https://imgur.com/a/UMJkw#ZyxWikW

{F} Any <3 for Librarians? https://imgur.com/a/YlRLj#bEuCbES

(F) Who's ready for dessert? {part 2} https://imgur.com/a/LtLxW#0

(F)or All The Good Boys And Girls: Dessert {part 3} https://imgur.com/a/6olDN#0

They seem to either not be detected/not downloaded. I'm not sure which. Hopefully you can replicate the bug. If I am missing something again please let me know.

Sorry for all fuss. It's not urgent, just whenever you have time to look at it. Thanks again!

AAndyProgram commented 1 year ago

Confirmed. I'll fix it tomorrow.

AAndyProgram commented 1 year ago

Fixed (I decided to fix it today😊). Please update to the latest release.

Thank you for providing problematic links and for such detailed information. Hope everything goes well this time.

Sorry for all fuss. It's not urgent, just whenever you have time to look at it.

Please feel free to ask questions and post problems.

AAndyProgram commented 1 year ago

Is everything okay this time?

twosushi commented 1 year ago

Is everything okay this time?

Yes, it's all fixed. I will close the thread as well. Thanks!