AAndyProgram / SCrawler

🏳️‍🌈 Media downloader from any sites, including Twitter, Reddit, Instagram, Threads, Facebook, OnlyFans, YouTube, Pinterest, PornHub, XHamster, XVIDEOS, ThisVid etc.
https://discord.gg/uFNUXvFFmg
GNU General Public License v3.0
1.29k stars 85 forks source link

[BUG] Video downloader doesnt workig for xh, ph, xv #106

Closed blackgur closed 1 year ago

blackgur commented 1 year ago

Downloading videos for ph, xh, xv does not work. The program caches the video, but the end result is that the final video files are not there. Instead, all videos go into "missing posts". https://i.imgur.com/bn0MCTi.png

Downloading for reddit and twitter works fine.

I'm using scrawler 2023.2.5.0 x64 Windows 11 x64

blackgur commented 1 year ago

I solved the problem. The problem was the Cyrillic alphabet in the path.

AAndyProgram commented 1 year ago

I think it's a duplicate of #99, but I didn't get feedback with the problem URL so I can't fix it. If you want, you can post a link to the problematic video here or text me on Discord (AndyProgram#3804) and I'll try to fix it.

blackgur commented 1 year ago

I don't think it's the same thing. I had a problem that windows explorer had a path with Russian letters to scrawler.exe

So absolutely any profiles from ph, xh, xv would not load but only cached.

AAndyProgram commented 1 year ago

Okay. Like I said "if you want". I think there is a problem with some characters, but until I get an example, I can't fix it. In your case I need the path you used in your language. I'm sure I can create the same path to identify the error. But if you don't want to, then fine.

blackgur commented 1 year ago

Try creating a folder named "папка_тест", put a clean build of scrawler there, and try downloading something from ph, xv, or xh

AAndyProgram commented 1 year ago

Okay

AAndyProgram commented 1 year ago

Confirmed. I would appreciate a link to a video named in your language to fix the problem with these characters.

blackgur commented 1 year ago

I tried to download the profile https://rt.pornhub.com/model/dominatrixannette But there is no video with Cyrillic in the title. So I think it's because of the Cyrillic in the name of the folder where the scrawler is

AAndyProgram commented 1 year ago

Unfortunately no. SCrawler has successfully downloaded parts of the video. There's a problem when he tried to combine them. I think the folder name is enough to fix this, but to be sure, it's better to have a link to a video containing these characters.

Okay, I'll try to fix it for the next release. But if you see a video with these characters, please send me a link.

blackgur commented 1 year ago

Also, there are difficulties with videos with emoji in the title. Sample: https://www.pornhub.com/view_video.php?viewkey=ph61f92c8fb188b

blackgur commented 1 year ago

Clean it up and lock conversation until it is resolved by you. Thank you.

AAndyProgram commented 1 year ago

Also, there are difficulties with videos with emoji in the title. Sample: https://www.pornhub.com/view_video.php?viewkey=ph61f92c8fb188b

Found a bug. Will be fixed in the next version.

Try creating a folder named "папка_тест", put a clean build of scrawler there, and try downloading something from ph, xv, or xh

Found a bug. Actually, this is not my bug. This is an ~ffmpeg~ CMD bug. Encoding transition or something.

  1. I updated ffmpeg to the latest version.
  2. Before executing I added the chcp 1251 command to change the CMD code page.

Now everything is all right. A few days for testing.

AAndyProgram commented 1 year ago

Fixed. Please update to the latest release.

AAndyProgram commented 1 year ago

I've added cmd encoding setting. The default is 65001 (Unicode). In your case, you need to set this value to 1251. Please update to the latest release.