AAndyProgram / SCrawler

🏳️‍🌈 Media downloader from any sites, including Twitter, Reddit, Instagram, Threads, Facebook, OnlyFans, YouTube, Pinterest, PornHub, XHamster, XVIDEOS, ThisVid etc.
https://discord.gg/uFNUXvFFmg
GNU General Public License v3.0
1.29k stars 85 forks source link

[REQUEST] SCrawler does not check system environment variables for ffmpeg #73

Closed reichbc closed 2 years ago

reichbc commented 2 years ago

Describe the bug When starting the program, it tells me "ffmpeg.exe is missing" despite the program being installed on my machine and being in the PATH variable systemwide.

Expected behavior Program should check local folder first for the existence of ffmpeg.exe, and then it should check user and system environment variables to see if it exists elsewhere on the system.

Screenshots https://ramstik.pictures/ath-58fc9.png https://ramstik.pictures/ath-cdad9.png https://ramstik.pictures/ath-7d29b.png

Release information (please complete the following information):

AAndyProgram commented 2 years ago

It's not a bug. Indeed, SCrawler doesn't check system variables. ffmpeg must be placed in the SCrawler path.

Program should check local folder first for the existence of ffmpeg.exe, and then it should check user and system environment variables to see if it exists elsewhere on the system.

Actually, no. You can use another developer's version of ffmpeg. ffmpeg might be a different version too. Versions may differ in commands and functions.

This will not be implemented. Sorry.

reichbc commented 2 years ago

chock this up to being the first program i've ever seen that won't allow the end user the choice of what installation of a dependency to use. If you're not going to offer the choice to to the users due to versioning and command differences, then bundle the version of ffmpeg you want with the program.

AAndyProgram commented 2 years ago

Excuse me, which choice do you want? At the end of the description of each release I have posted, I give links where you can download the version of ffmpeg that I used. I don't understand what the problem is. Btw, SCrawler works even without ffmpeg. ffmpeg is only needed to download videos hosted on Reddit and create images for video in the feed. image

AAndyProgram commented 2 years ago

I forgot, ffmpeg is also needed to download videos from xvideos.