Make the generator cancellable

AArnott / CodeGeneration.Roslyn

Assists in performing Roslyn-based code generation during a build.

Microsoft Public License

408 stars 60 forks source link

Make the generator cancellable #187

Closed manne closed 4 years ago

manne commented 4 years ago

I did not spend much time where the CancellationTokens are observed and how to behave on the cancellation. I am open for suggestions.

manne commented 4 years ago

@amis92 I incorporated your feedback. Should I undo the unassociated changes in CompilationGenerator too?

manne commented 4 years ago

@amis92 I hope to be able to work on the requested changes during the weekend

AArnott commented 4 years ago

Thanks, @amis92. I'll take a look.

manne commented 4 years ago

@AArnott, @amis92 I see that both of you approved this PR. From my point of view this PR can be merged. I am not allowed to to this. Should I change something?