search

AArnott / CodeGeneration.Roslyn

Assists in performing Roslyn-based code generation during a build.
Microsoft Public License
408 stars 59 forks source link

Nuget update Microsoft.CodeAnalysis.CSharp to 2.2.0 #39

Closed Pzixel closed 7 years ago

Pzixel commented 7 years ago

I found that I'm unable to use C# 7.0 features such as throw expression or value tuples. If I update packages locally I'm unable to build solution due to fails in nuget dependency consolidation mechanism. So I propose to update your nuget up to date. It doesn't require any additional dependencies, doesn't require higher NetStandard, so I don't see any problems here.

AArnott commented 7 years ago

Thanks for contributing

Pzixel commented 7 years ago

I glad to contribute :) Waiting for a nuget package.

AArnott commented 7 years ago

published

Pzixel commented 7 years ago

That's weird but my problem still here. After updating to 2.2.0 it doesn't work. See pull request, the only change is updating to 0.4.11: https://github.com/Pzixel/RemoteClient.Roslyn/pull/3/files . I also changed NetStandard to 1.5, but it doesn't matter, it doesn't work with 1.6 too. And here is build of master which is ok: https://github.com/Pzixel/RemoteClient.Roslyn/tree/master

I investigated for a while but found nothing. Moving to 2.2.0 is breaking code somehow. Even if my generator do nothing except returning an empty class declaration without any complex logic.

AArnott commented 7 years ago

OK. I thought you'd already tested this and found that it resolved your issue. For now, I've unlisted the 0.4.11 release from nuget.org to avoid it breaking anyone since I didn't personally test it either. It's still there on nuget.org so you can keep trying if you want by naming the version exactly..

Pzixel commented 7 years ago

@AArnott You can publish this package back. It's my fault: dotnet-codegen 0.4.9 is not compatible with CodeAnalysis 2.2.0. <DotNetCliToolReference Include="dotnet-codegen" Version="0.4.11" /> solves the problem.

AArnott commented 7 years ago

Great. Thanks for the update. I've re-listed 0.4.11 packages.