search

AArnott / CodeGeneration.Roslyn

Assists in performing Roslyn-based code generation during a build.
Microsoft Public License
408 stars 59 forks source link

Added Assembly Resolve #62

Closed LokiMidgard closed 6 years ago

LokiMidgard commented 6 years ago

Added logic to resolve referenced assemblies of generator assembly.

This should prevent problems with generators that uses other assemblies described in #61.

To use DependencyContext it was necessary to push target framework version to netstandard 1.6.

LokiMidgard commented 6 years ago

I also updated NedbankGitVersioning to 2.1.23 and removed the hack that was previous needed since Appveyor updated there build tools.

I hope you do not mind that I mix this up with this issue.

LokiMidgard commented 6 years ago

any feedback on this?

AArnott commented 6 years ago

@LokiMidgard The NB.GV upgrade is good, as is the workaround that you removed. But you removed a bit too much (more than the workaround) so I brought that back.

Honestly, I don't understand the assembly resolving changes you've made. I'm taking your word for it. But it's at risk that I might break it at some point since you didn't add any tests to lock in the behavior that you need. I'll complete this PR, but I encourage you to follow up with another PR that adds tests so I don't break you in the future.