AArnott / CodeGeneration.Roslyn

Assists in performing Roslyn-based code generation during a build.
Microsoft Public License
408 stars 59 forks source link

NuGet packages v0.4.37 have incorrect dependencies #68

Closed amis92 closed 6 years ago

amis92 commented 6 years ago

Something went wrong with building NuGet packages, because they all require "1.0.0" of the other project dependencies, namely:

All packages have package and assembly version set correctly to 0.4.37.

cc @AArnott @Pzixel

Pzixel commented 6 years ago

To prevent this in the future i'm working on referencing nuget packages that are packed during test instead of referencing projects directly. Brb when I'm done. It also may help to detect what's wrong.

amis92 commented 6 years ago

It definitely looks like a ~regression of~ https://github.com/AArnott/Nerdbank.GitVersioning/issues/113

EDIT: strikethrough because it seems this project didn't update the Nerdbank.GitVersioning to 2.1.23+ :D

Pzixel commented 6 years ago

Good catch.

It's also interesting that my VS hangs when I'm trying to update this package

Pzixel commented 6 years ago

Created a PR: https://github.com/AArnott/Nerdbank.MSBuildExtension/pull/1 . I hope it gets fixed quickly. When it get's merged we need syncronous update in this repo. It also would be nice if @AArnott could just push it in master when MSBuildExtension gets updated.

AArnott commented 6 years ago

I don't see how this is related to https://github.com/AArnott/Nerdbank.MSBuildExtension/pull/1. That project doesn't determine the package versions/dependencies of its consumers like this project.

I can see from the CI build that this issue is already fixed. Probably by #62

Pzixel commented 6 years ago

@AArnott you're right, I just was searching for possible bad guys in the entire dependency tree :)

Waiting for an updated published nuget.

AArnott commented 6 years ago

Published.