AArnott / CodeGeneration.Roslyn

Assists in performing Roslyn-based code generation during a build.
Microsoft Public License
408 stars 59 forks source link

Add prefercliruntime file to dotnet-codegen CLI tool #85

Closed amis92 closed 5 years ago

amis92 commented 6 years ago

It might or might not resolve issues like #84 (no 1.0 shared fx).

Pending check.

The file usage is not yet (well) documented, pending https://github.com/dotnet/docs/issues/7292

AArnott commented 6 years ago

I expect #86 will also take care of #84. I'll check it today. If so, I may not take this PR since it uses an as-yet undocumented feature. But thank you for the submission either way.

AArnott commented 6 years ago

I've verified that #86 fixes #84. Closing this.

amis92 commented 5 years ago

Benefits provided, according to an implementation:

Currently, we require customers using the generators to run the build on a machine with .NET Core v2.0 runtime available, which is currently out of support officially. It's not critical, but it's a kind of a papercuts issue.

Also no issue with compatibility since we target the lowest applicable, netcoreapp2.0 (it'll run on every .NET Core runtime v2.x)

amis92 commented 5 years ago

Sooo now there's a bit more "official" documentation on the topic of prefercliruntime: https://github.com/dotnet/docs/issues/7292#issuecomment-497031254

Comment added for future references