search

AArnott / Library.Template

A template for a NuGet package with tests, stylecop, fxcop, versioning, and Azure Pipelines build ready to go.
MIT License
131 stars 26 forks source link

Convert-PDB.ps1 has incorrect 'synopsis' #24

Closed Eilon closed 4 years ago

Eilon commented 5 years ago

See this line:

https://github.com/AArnott/Library.Template/blob/a2556bf66ce72ef84c33077b94a9c83100d88e37/azure-pipelines/Convert-PDB.ps1#L3

It looks like this file was copied from somewhere, but I can't tell from where. It's in several places across GitHub:

https://github.com/search?utf8=✓&q=filename%3Aconvert-pdb.ps1&type=Code&ref=advsearch&l=&l=

The synopsis should be changed to a correct description of the utility. Something like, Converts between Windows PDB and Portable PDB formats. (text taken from https://github.com/dotnet/symreader-converter#microsoftdiasymreaderconverter).

AArnott commented 4 years ago

Wow. Mistakes die hard. I think I am the original author of this script. Interesting to see how far the script has spread. Anyway, nice catch. I'll get this fixed.

Eilon commented 4 years ago

Hilarious. Thanks for fixing!