AArnott / PCLCrypto

Platform crypto for portable libraries
Microsoft Public License
229 stars 55 forks source link

.NET Core support #103

Closed AArnott closed 6 years ago

AArnott commented 8 years ago

Package up with runtime assemblies in nuget packages at minimum. Consider supporting OSX, Linux.

ghost commented 8 years ago

I currently need it in a project for Windows 10. It would be cool to support .NETStandard,Version=v1.3. Thx

Trolldemorted commented 7 years ago

support for .NETStandard would be great indeed.

do you have plans for this in the near future?

AArnott commented 7 years ago

Yes. Just as soon as dotnet/sdk#650 and dotnet/sdk#651 are fixed, I think I'll be unblocked in utilizing VS2017 to build the netstandard supporting library.

In the meantime, I can probably makeshift it with NuProj. NetStandard support is easier than .NET Core support. @Trolldemorted did you mean to distinguish the two?

adminnz commented 7 years ago

Looks like those two dotnet/sdk issues are resolved for you? What is the status of this project supporting .NET core ?

AArnott commented 7 years ago

Yes, I suspect I'm unblocked now. Just need to find time. To be clear, what are you looking for? .NET Core support for running on which OS(s)?

adminnz commented 7 years ago

I'm mainly looking at this because its used in Microsoft's Azure IoT Device Client which I'm porting to .NET Core for Linux (specifically Ubuntu)

AArnott commented 7 years ago

I see. Thanks. I hope to get to this within the next few weeks. What's your timeframe requirements?

adminnz commented 7 years ago

Obviously the sooner the better, but 1-3 weeks is fine.

AArnott commented 7 years ago

It's going to be a significant effort. Both to refactor the entire solution to use .NET SDK projects, and then to add support for .netstandard1.6 (or whatever version adds the crypto APIs). So although I think I can start in that timeframe, I don't know how long it will take me. Hopefully not too much longer, but this is a side project for me so "as time permits" is the constraint I'm under.

AArnott commented 7 years ago

Work has started in the SDKProj branch.

AArnott commented 7 years ago

@adminnz So maybe we got lucky. I spent a few hours last night and this morning to get this going. It's very early, but I have a package that supports .NET Core. It will throw PlatformNotSupportedException in quite a few cases, but perhaps it's enough for your scenario? Let me know.

NuGet feed: https://ci.appveyor.com/nuget/pclcrypto Package version: 2.1.6-alpha-g60d2508d50

AArnott commented 7 years ago

I have a new package version with much better .NET Core support: 2.1.13-alpha+g51fc118017

Please use the NuGet feed mentioned in my previous comment.

francisrath commented 6 years ago

I can't get 2.1.13-alpha+g51fc118017 or the latest test build to work in my Universal Windows app when building with .net native (which is a requirement for the Store). Do you have any updates on this, or maybe someone could help me convert a rather simple decryption method from PCLCrypto to something that would natively work in my Windows 10 app?

Thanks in advance!

scharada commented 6 years ago

hi. is there any plan to make the library for the latest netstandard20 ? thank you

AArnott commented 6 years ago

@scharada and others: I've just pushed 2.1.17-alpha-g5b1e8dff8c to nuget.org with .NET Core and .NETStandard support. Please send your feedback. It's almost completely untested, so no guarantees.

@francisrath You're probably hitting #137 which is a Windows bug that Microsoft is working on. Nothing I can do about it, sadly.