search

AArnott / Validation

Method input validation and runtime checks that report errors or throw exceptions when failures are detected.
Microsoft Public License
131 stars 22 forks source link

Remove dependencies #96

Closed bdovaz closed 2 years ago

bdovaz commented 2 years ago

Remove unnecessary System.Runtime.InteropServices dependency.

codecov-commenter commented 2 years ago

Codecov Report

Merging #96 (6141a54) into master (95eff87) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #96   +/-   ##
=======================================
  Coverage   91.43%   91.43%           
=======================================
  Files           9        9           
  Lines         292      292           
=======================================
  Hits          267      267           
  Misses         25       25

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 95eff87...6141a54. Read the comment docs.

bdovaz commented 2 years ago

@AArnott can you release a new NuGet package version without this dependency? Thanks.

AArnott commented 2 years ago

How is this blocking you?

bdovaz commented 2 years ago

Yes because we use it with Unity and it only supports .NET Standard 2.0 / 2.1 packages.

We use it with:

https://github.com/xoofx/UnityNuGet

AArnott commented 2 years ago

Ok. 2.6.13-beta is on its way to nuget.org now.

bdovaz commented 2 years ago

Thanks, but that UnityNuGet library only works with stable versions...

AArnott commented 2 years ago

Then you'll need to send a PR to our latest stable branch instead of our main development branch.

bdovaz commented 2 years ago

@AArnott what's branch is it?

https://github.com/AArnott/Validation/branches/all

Thanks!

AArnott commented 2 years ago

Oh, gosh. I guess in this repo I don't have a stable branch for v2.5. Let me get back to you on that.

AArnott commented 2 years ago

Ok. I've pushed a v2.5 branch and cherry-picked your change to it. We'll get a stable 2.5 release out to nuget.org today.