AArnott / Xunit.Combinatorial

Adds combinatorial and pairwise testing capability to Xunit tests
Other
180 stars 16 forks source link

Support .NET Framework #10

Closed cmeeren closed 7 years ago

cmeeren commented 7 years ago

I'd like to see support for .NET Framework. Currently, when installing the package (.NET Standard) in a .NET Framework project, it installs tons of dependencies (.NET Standard stuff). I'm sure that just by targeting .NET Framework too, most if not all of them could be eliminated.

I think it's just a matter of editing a few things in the csproj file.

(FYI: .NET Standard test projects doesn't play well with ReSharper, that's why I need this.)

cmeeren commented 7 years ago

Note that this is an actual problem, not simply a matter of "living with all the .NET Standard packages". When I installed Xunit.Combinatorial into a .NET Framework test project, all the .NET Standard packages immediately broke quite a few tests (relating to some System.Web stuff).

I've made a very simple PR that adds support for .NET 4.5. Tested and verified.

AArnott commented 7 years ago

Closed with fa9f00a