search

AArnott / Xunit.Combinatorial

Adds combinatorial and pairwise testing capability to Xunit tests
Other
180 stars 16 forks source link

Support CombinatorialMemberData for IEnumerable<string> #55

Closed siewers closed 1 year ago

siewers commented 1 year ago

Fixes #54

siewers commented 1 year ago

I don't know why the build fails. I changed the pinned .NET SDK version to 6.0.401, which is the latest .NET 6 version. Otherwise, I couldn't get it to build locally. I don't think it's the reason it fails though.

I decided to remove the check and test for non-generic IEnumerable return types, as the next error message clearly explains the return type should implement the generic IEnumerable<T>.

Besides that, I added explicit checks for IEnumerable<T[]> and IEnumerable<IEnumerable<T>>. I'm not sure if it's strictly necessary to split it, but I don't think it hurts to be explicit and return a descriptive message about any expected common mistakes the user might make.

siewers commented 1 year ago

@AArnott I know you might be busy, but this is blocking me from using this library at the moment. Would you be able to have a look? Thanks 🙂

AArnott commented 1 year ago

Yes, thank you for submitting the change. I'll take a look.

timba commented 1 year ago

The latest stable version v1.5.25 doesn't include this fix. Any plans releasing it anytime soon?

AArnott commented 1 year ago

Published v1.6.24 to nuget.