search

AArnott / Xunit.StaFact

Run your xunit-based tests on an STA thread with the WPF Dispatcher, a WinForms SynchronizationContext, or even a cross-platform generic UI thread emulation with a SynchronizationContext that keeps code running on a "main thread" for that test.
Other
92 stars 31 forks source link

Change all `Cocoa` references to `AppKit` #74

Closed AArnott closed 1 year ago

AArnott commented 1 year ago

It turns out that "Cocoa" refers to the overall API, including "AppKit" which is the actual UI layer. By being precise in our naming here, if "Cocoa" or macOS ever move on to a new UI framework, maybe "Cocoa" will live on, but with the new UI libraries. We could support both, but not if both were called "Cocoa".

AArnott commented 1 year ago

@SiyuGithub do you have any concerns with this?

SiyuGithub commented 1 year ago

It looks good to me. AppKit sounds like a better name in here. But since I am no longer work in the VSMac team, can we confirm this renaming with @sandyarmstrong too? Thanks.

sandyarmstrong commented 1 year ago

I don't think I agree with this. The UI thread concept is implemented in the Foundation layer (via NSRunLoop), not the AppKit layer. CocoaFact should work just as well with AppKit apps as it would with SwiftUI apps (if there were ever managed bindings for that). I think "Cocoa" is the most recognizable term that encompasses this.

AArnott commented 1 year ago

Great. Thanks for your insight. I'll close the PR.