Trade: Use mypy annotation for cythonization instead of via .pyx file

AB-CE / abce

Agent-based computational Economics, the Python library that makes AB modelling easier

http://abce.readthedocs.io

181 stars 62 forks source link

Trade: Use mypy annotation for cythonization instead of via .pyx file #178

Closed rht closed 5 years ago

rht commented 5 years ago

@DavoudTaghawiNejad here is the benchmark result of running unittest on my machine:

current master:

python start.py 120.99s user 25.31s system 195% cpu 1:14.75 total
python start.py 119.73s user 24.12s system 193% cpu 1:14.44 total

mypy-cython:

python start.py 114.22s user 23.17s system 196% cpu 1:10.04 total
python start.py 122.78s user 24.71s system 192% cpu 1:16.51 total

pure python:

python start.py 121.84s user 24.58s system 192% cpu 1:15.98 total
python start.py 119.54s user 23.95s system 194% cpu 1:13.77 total

rht commented 5 years ago

@DavoudTaghawiNejad, @DavoudTaghawiNejad, @DavoudTaghawiNejad the 4th commit (even though the change is minimum) speeds up the unittest runtime a lot:

python start.py  106.95s user 23.05s system 200% cpu 1:04.73 total
python start.py  107.39s user 23.18s system 201% cpu 1:04.83 total

rht commented 5 years ago

@DavoudTaghawiNejad this is the optimal level of annotation. Precisifying further (e.g. replacing sender's object with tuple) etc only makes it worse.

DavoudTaghawiNejad commented 5 years ago

Issue 167 must be merged in first. It's a nasty floating point error.

rht commented 5 years ago

The other option is to use .pxd files instead.

rht commented 5 years ago

Superseded by #182.