Closed Varstahl closed 4 years ago
Code looks fine but I would like some (additional) clarification.
It's a great idea but I want to make sure its inclusion is justified. I suppose once you import it, the column is removable so I'll likely accept this PR anyway.
Could you show me some sample output?
Why do you feel this is necessary
It's not necessary per se, but it's one of the things I wanted from this tool, in order to generate a separate file from the resulting csv with some of the aggregated information. In the scope of having the dump modularised, I thought that it couldn't hurt if this was the first thing I worked on.
To be honest I wanted to add three separate columns for the images, even though I was only interested in the verticalCover
, but I didn't know if that was in line with how the rest of the CSV is generated.
I was planning to work today on a parameter based extraction and CSV generation, to let the users decide what they want to export. I'm also looking to introduce an option for the game description, in a similar fashion.
I can still change this in any way you feel necessary.
Sounds neat enough. I'll gladly accept this but I think it may be better if you split the images into three columns.
I also agree that parameter based output would be nice since we're starting to extract a lot of info from the DB. Feel free to add the description query any time.
Alright then, I'll work on the parameterization and update this PR later.
I'm merging this. Open a separate PR for that since it'll be easier to track.
Thank you so much for your contribution!
I wanted to export Galaxy's game list in a nice browsable way, and so I worked the
originalImages
extraction into the tool. It's also a nice way to filter out DLCs, since they don't have full images by themselves.The column has a comma separated list of
type:<url>
images, if available.