AB1908 / GOG-Galaxy-Export-Script

Export your list of games from GOG Galaxy
MIT License
150 stars 27 forks source link

added original images to the export data #22

Closed Varstahl closed 4 years ago

Varstahl commented 4 years ago

I wanted to export Galaxy's game list in a nice browsable way, and so I worked the originalImages extraction into the tool. It's also a nice way to filter out DLCs, since they don't have full images by themselves.

The column has a comma separated list of type:<url> images, if available.

AB1908 commented 4 years ago

Code looks fine but I would like some (additional) clarification.

It's a great idea but I want to make sure its inclusion is justified. I suppose once you import it, the column is removable so I'll likely accept this PR anyway.

Varstahl commented 4 years ago

Could you show me some sample output?

title images
1... 2... 3... KICK IT! background:https://images.gog.com/846c5c41dfaf6b7a0cf627ad05796884acedc233fa8fb45102296f372abcaf7d_glx_bg_top_padding_7.webp?namespace=gamesdb
,squareIcon:https://images.gog.com/9dbe1a867bb3f793f87e0fa124c4db50eaad70846658fb38df69795b00343ec8_glx_square_icon_v2.webp?namespace=gamesdb
,verticalCover:https://images.gog.com/9dbe1a867bb3f793f87e0fa124c4db50eaad70846658fb38df69795b00343ec8_glx_vertical_cover.webp?namespace=gamesdb
10 Second Ninja X background:https://images.gog.com/640c97dd51fbb5eb6240d0d7e2765e223d46e1b9f92ce4d9f5db7992f4ced293_glx_bg_top_padding_7.webp?namespace=gamesdb
,squareIcon:https://images.gog.com/0e5c2d83fd7cd9671fb675e7613df9a4ee7c04a05bf1b3957f63caa28bad31fd_glx_square_icon_v2.webp?namespace=gamesdb
,verticalCover:https://images.gog.com/4df641c4cada7d9a9d3e76ac76581e4733d84d0a7030fd9de9322c9bf8b423d3_glx_vertical_cover.webp?namespace=gamesdb

Why do you feel this is necessary

It's not necessary per se, but it's one of the things I wanted from this tool, in order to generate a separate file from the resulting csv with some of the aggregated information. In the scope of having the dump modularised, I thought that it couldn't hurt if this was the first thing I worked on.

To be honest I wanted to add three separate columns for the images, even though I was only interested in the verticalCover, but I didn't know if that was in line with how the rest of the CSV is generated.

I was planning to work today on a parameter based extraction and CSV generation, to let the users decide what they want to export. I'm also looking to introduce an option for the game description, in a similar fashion.

I can still change this in any way you feel necessary.

AB1908 commented 4 years ago

Sounds neat enough. I'll gladly accept this but I think it may be better if you split the images into three columns.

I also agree that parameter based output would be nice since we're starting to extract a lot of info from the DB. Feel free to add the description query any time.

Varstahl commented 4 years ago

Alright then, I'll work on the parameterization and update this PR later.

AB1908 commented 4 years ago

I'm merging this. Open a separate PR for that since it'll be easier to track.

Thank you so much for your contribution!