search

AB1908 / GOG-Galaxy-Export-Script

Export your list of games from GOG Galaxy
MIT License
149 stars 27 forks source link

platformList inaccurate #3

Closed toastmonster closed 4 years ago

toastmonster commented 4 years ago

Products owned in the GOG store are shown as owned in "Placeholder". Products owned on Twitch are usually shown as being owned on additional platforms, example "Twitch,Itch.io" or "Twitch,Itch.io,BlackBerry Games??". Products owned in Humble Bundle are usually shown as being owned on additional platforms, example "Humble Bundle,Nintendo DS" or "Humble Bundle,Steam,Nintendo Entertainment System".

AB1908 commented 4 years ago

The Humble Bundle Keys require some more logic, I definitely agree there. It's a byproduct of how they name their keys. For example, if I have a Steam key on HB, it's labeled something like humble_witcher_3_steam. I'll think of a way to fix this and am also open to suggestions. As for Twitch products, I'm not sure. Could you find the relevant releaseKey for an idea of why it's bugging out? I'll take a look at the GOG entries.

AB1908 commented 4 years ago

Oh, it looks like while updating the platform list, I just kinda skipped GOG. Fixing.

AB1908 commented 4 years ago

Ah I think I know how to fix the Humble Bundle parsing. I should use startsWith. I'll fix this and push it after a little testing.

AB1908 commented 4 years ago

@toastmonster : Could you pull my fix branch to test if it works?

toastmonster commented 4 years ago

@AB1908 PlatformList looks accurate to me now, good job!

AB1908 commented 4 years ago

Haha this was going to be autoclosed by the PR. Ya didn't have to close it.