search

AB1908 / GOG-Galaxy-Export-Script

Export your list of games from GOG Galaxy
MIT License
153 stars 27 forks source link

At least 1 game missing from export #32

Closed toastmonster closed 4 years ago

toastmonster commented 4 years ago

I noticed that my export using the latest release is missing at least one game.

You'll notice in the screenshot below that I have all 5 episodes of "3 out of 10" from Epic Games Store, yet the exported file is missing episode 2, "Foundation 101".

missing game

toastmonster commented 4 years ago

It's definitely not there in the raw export file either, by the way.

Varstahl commented 4 years ago

Episode 2 is in the CSV but there's something wrong, on that you're right.

AB1908 commented 4 years ago

This looks like an interesting bug. @Varstahl, can I have a crack at it?

Varstahl commented 4 years ago

3 out of 10 episode 2 is counted as DLC for Episode 1. Apparently Epic switched mid release. We need special rulesets for it I think, if we can actually do anything. @AB1908 sure thing, I was about to look into the DB myself, go on.

AB1908 commented 4 years ago

I'll look into it in a few hours. Thanks for the quick debug info!

Varstahl commented 4 years ago

I went ahead 'cause the curiosity got the best of me, and as I was supposing a dirty fix requires a single line of code. A few more if we want to do things better, in case this problem returns.

I'm not spoiling the solution though, it's a good exercise to familiarise with the codebase :)

toastmonster commented 4 years ago

Perhaps an optional switch to include (or exclude) DLC?

On Sun, 18 Oct 2020 at 16:10, Bruno Passeri notifications@github.com wrote:

I went ahead 'cause the curiosity got the best of me, and as I was supposing a dirty fix requires a single line of code. A few more if we want to do things better, in case this problem returns.

I'm not spoiling the solution though, it's a good exercise to familiarise with the codebase :)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/AB1908/GOG-Galaxy-Export-Script/issues/32#issuecomment-711208625, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABUI6MWUKFQPDR6QN3D6DWDSLMAOBANCNFSM4SURAG2Q .

Varstahl commented 4 years ago

@AB1908 the fix is ready to be merged (#33), along with the export by default you requested previously (#30) and the ability to now sort the export data as the user wants, by keeping track of the user modified sortingTitle (#34).