search

ABAPlan / abaplan-core

Core ABAPlan project
MIT License
4 stars 2 forks source link

Loading state image still running when an OSM layer has loaded #81

Closed jcavat closed 7 years ago

jcavat commented 7 years ago

Maybe due to #80.

How to reproduce:

  1. Load a map
  2. Change immediately the layer to OSM
jcavat commented 7 years ago

Network inspection shows that the layer is still waiting for resources... Even if we switch to OSM layer

maximeburri commented 7 years ago

To fix that we need to use layer load/finish events instead of map.

Layers events do not seem to work : https://github.com/ABAPlan/abaplan-core/blob/fix-loading-%2381/app/core/map.ts#L66-L92

maximeburri commented 7 years ago

Layers events seem to work in layer-add : https://github.com/ABAPlan/abaplan-core/blob/fix-loading-%2381/app/core/map.ts#L56-L84

jcavat commented 7 years ago

procrastination ?

maximeburri commented 7 years ago

Issue closed. Loading image is not shown anymore, but layer not visible are always loading images (in network inspection). Nothing to do.. layer.suspend(), layer.hide() or layer.setVisibility(false) don't stop these requests..

jcavat commented 7 years ago

I think it's normal because each request involve a response.

maximeburri commented 7 years ago

Not always, because if you go in "City", after "Osm" after "City", requests of first "City" is canceled. image