search

ABAPlan / abaplan-core

Core ABAPlan project
MIT License
4 stars 2 forks source link

HTTPS to HTTP request issue when looking for public transports #99

Closed Ettapp closed 6 years ago

Ettapp commented 6 years ago

Location

In the touchpad-voice app.

Description

When saying "Stop transport" / "Stop transport " in any supported language, nothing appends.

Then looking on the DevTools's network tool, we can see that the request are well sent, but are blocked by the browser for security concerns (mixed contents): The app is served over HTTPS and try to request insecure (HTTP) enpoint: http://transport.opendata.ch/....

Reproduction procedure

  1. Open the touchpad-voice app
  2. Select a point by pressing anywhere on the tactile dalle
  3. Try to use the transport mode by saying "stop transport" in any supported language
Ettapp commented 6 years ago

I used the Chrome DevTools to change the url at run time to check if the opendata server was able to handle requests over https, as the information don't seems to be anywhere on their documentation, and to check if this would solve the issue, and it does.

I created a pull request to programmatically solve the issue: #100

Suggestion: Move all the configuration data (like the api url) outside of the code files.