search

ABAtanasov / GalerkinSparseGrids.jl

Sparse Grid Discretization with the Discontinuous Galerkin Method for solving PDEs
Other
47 stars 14 forks source link

Speed up code, output operators and solution #7

Closed eschnett closed 5 years ago

ABAtanasov commented 5 years ago

Hey Erik - I'm noticing that the tests aren't passing on this branch. It looks like its something related to MKLSparse. Is there a quick fix for this?

eschnett commented 5 years ago

I might be that MKL needs to be installed on AppVeyor. I'll have a look.

codecov[bot] commented 5 years ago

Codecov Report

Merging #7 into master will increase coverage by 1.89%. The diff coverage is 62.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #7      +/-   ##
==========================================
+ Coverage   59.97%   61.87%   +1.89%     
==========================================
  Files          16       17       +1     
  Lines         827      960     +133     
==========================================
+ Hits          496      594      +98     
- Misses        331      366      +35
Impacted Files Coverage Δ
src/GalerkinSparseGrids.jl 100% <ø> (ø)
src/schemes.jl 100% <ø> (+20%) :arrow_up:
src/filtering.jl 0% <0%> (ø) :arrow_up:
src/basic_function_exact_coeffs.jl 0% <0%> (ø) :arrow_up:
src/error_measure.jl 0% <0%> (ø) :arrow_up:
src/tensor_construct.jl 0% <0%> (ø) :arrow_up:
src/dg_vmethods.jl 100% <100%> (ø) :arrow_up:
src/dg_basis.jl 98.5% <100%> (+0.43%) :arrow_up:
src/dg_methods.jl 100% <100%> (ø) :arrow_up:
src/additional_tools.jl 100% <100%> (+7.69%) :arrow_up:
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f6fc491...0f04ae6. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #7 into master will increase coverage by 1.77%. The diff coverage is 62.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #7      +/-   ##
==========================================
+ Coverage   59.97%   61.74%   +1.77%     
==========================================
  Files          16       17       +1     
  Lines         827      962     +135     
==========================================
+ Hits          496      594      +98     
- Misses        331      368      +37
Impacted Files Coverage Δ
src/GalerkinSparseGrids.jl 100% <ø> (ø)
src/schemes.jl 100% <ø> (+20%) :arrow_up:
src/filtering.jl 0% <0%> (ø) :arrow_up:
src/basic_function_exact_coeffs.jl 0% <0%> (ø) :arrow_up:
src/error_measure.jl 0% <0%> (ø) :arrow_up:
src/tensor_construct.jl 0% <0%> (ø) :arrow_up:
src/dg_vmethods.jl 100% <100%> (ø) :arrow_up:
src/dg_basis.jl 98.5% <100%> (+0.43%) :arrow_up:
src/dg_methods.jl 100% <100%> (ø) :arrow_up:
src/additional_tools.jl 100% <100%> (+7.69%) :arrow_up:
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f6fc491...e90f6ab. Read the comment docs.

eschnett commented 5 years ago

I added a check whether the MKL library is installed, and if not, I'm skipping using it. MKL is much faster than the alternative (SuiteSparse), but it's not necessary.