Update select search term window

fho4abcd commented 2 years ago

This commit rewrites diccionario.php. Main cause was an unreadable window for large search terms. Details:

The included files ifpro.php and ifepil.php are now contained in the main script. This makes the code much more readable.
The duplicate table html is replaced by some divs at the top of the window) + a single table (with 1 column) with one row to display the selection list and one row with action buttons (replacing the original lengthy text and links. Large terms do now no longer result in a corrupt display.
Many remains of older versions in the script are removed. Notes:
This script serves only central/dataentry. Copies of diccionario.php in other folders are not touched yet. The translations for these scripts are also still present
Error processing was not present and this is still the case.

edsz14 commented 2 years ago

Some comments :

the text 'copy terms to the search form' is misleading because it actually performs the search itself; copying to the search form could be a separate action or remains only done when the result is zero ?
it is already a significant improvement but 'click on continue' could be prevented by having the 'enter' key doing the same.
for documentation purpose it is good to mention that the 'broken multi-byte end-character´ (semi-)solution is re-introduced again here with the code : Termino=document.forma1.terminos.options[i].value; var index=Termino.indexOf(String.fromCharCode("65533")); if(index>=0){ Termino=Termino.substring(0,index-1); Termino+="$"; } This replaces with a truncation '$' the UTF8-character at the end when broken (corrupt) by the splitting in between LE1 and LE2 (resp. short and long terms max) in CISIS cifst.c code. On Monday, December 6, 2021, 10:37:41 PM GMT+1, Fred @.***> wrote:

This commit rewrites diccionario.php. Main cause was an unreadable window for large search terms. Details:

The included files ifpro.php and ifepil.php are now contained in the main script. This makes the code much more readable.
The duplicate table html is replaced by some divs at the top of the window) + a single table (with 1 column) with one row to display the selection list and one row with action buttons (replacing the original lengthy text and links. Large terms do now no longer result in a corrupt display.
Many remains of older versions in the script are removed.
Notes:
This script serves only central/dataentry. Copies of diccionario.php in other folders are not touched yet. The translations for these scripts are also still present
Error processing was not present and this is still the case.

You can view, comment on, or merge this pull request online at:

https://github.com/ABCD-DEVCOM/ABCD2/pull/232

Commit Summary

afca554 Update select search term window

File Changes

(4 files)

M www/htdocs/central/dataentry/diccionario.php (281)
D www/htdocs/central/dataentry/ifepil.php (47)
D www/htdocs/central/dataentry/ifpro.php (184)
M www/htdocs/central/lang/00/admin.tab (3)

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

edsz14 commented 2 years ago

Sorry, ignore the part on 'send to search form' of my previous comment, I now see there is a separate button (but it was still hidden to the extreme right of the sub-window... proving my point actually) for 'search' instead of 'send to search form'. Probably for my own use I might abbreviate the texts in central/lang/00 : Use the Ctrl or Shift keys to select more than one term. To advance to a term, type the first few letters as I still prefer the box to enter a term centralized above the list. On Monday, December 6, 2021, 10:37:41 PM GMT+1, Fred @.***> wrote:

This commit rewrites diccionario.php. Main cause was an unreadable window for large search terms. Details:

The included files ifpro.php and ifepil.php are now contained in the main script. This makes the code much more readable.
The duplicate table html is replaced by some divs at the top of the window) + a single table (with 1 column) with one row to display the selection list and one row with action buttons (replacing the original lengthy text and links. Large terms do now no longer result in a corrupt display.
Many remains of older versions in the script are removed.
Notes:
This script serves only central/dataentry. Copies of diccionario.php in other folders are not touched yet. The translations for these scripts are also still present
Error processing was not present and this is still the case.

You can view, comment on, or merge this pull request online at:

https://github.com/ABCD-DEVCOM/ABCD2/pull/232

Commit Summary

afca554 Update select search term window

File Changes

(4 files)

M www/htdocs/central/dataentry/diccionario.php (281)
D www/htdocs/central/dataentry/ifepil.php (47)
D www/htdocs/central/dataentry/ifpro.php (184)
M www/htdocs/central/lang/00/admin.tab (3)

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

edsz14 commented 2 years ago

Continuation : the distinction in between 'send to search form' and 'search' right now only exists in the search-function of the toolbar, not in the quick-search. This difference can be defended, therefore is acceptable to me. My abbreviated subwindow for the toolbar-search is shown in attached picture. On Monday, December 6, 2021, 10:37:41 PM GMT+1, Fred @.***> wrote:

This commit rewrites diccionario.php. Main cause was an unreadable window for large search terms. Details:

The included files ifpro.php and ifepil.php are now contained in the main script. This makes the code much more readable.
The duplicate table html is replaced by some divs at the top of the window) + a single table (with 1 column) with one row to display the selection list and one row with action buttons (replacing the original lengthy text and links. Large terms do now no longer result in a corrupt display.
Many remains of older versions in the script are removed.
Notes:
This script serves only central/dataentry. Copies of diccionario.php in other folders are not touched yet. The translations for these scripts are also still present
Error processing was not present and this is still the case.

You can view, comment on, or merge this pull request online at:

https://github.com/ABCD-DEVCOM/ABCD2/pull/232

Commit Summary

afca554 Update select search term window

File Changes

(4 files)

M www/htdocs/central/dataentry/diccionario.php (281)
D www/htdocs/central/dataentry/ifepil.php (47)
D www/htdocs/central/dataentry/ifpro.php (184)
M www/htdocs/central/lang/00/admin.tab (3)

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

edsz14 commented 2 years ago

The 'send to search form' in the sub-window for quick-search seems to have been confused with the 'search' button, i.e. the invoke the immediate search itself. So it should refer to the message 'src_advance' instead of 'src_send'. In the toolbar-search dictionary-window it seems OK. On Monday, December 6, 2021, 10:37:41 PM GMT+1, Fred @.***> wrote:

This commit rewrites diccionario.php. Main cause was an unreadable window for large search terms. Details:

The included files ifpro.php and ifepil.php are now contained in the main script. This makes the code much more readable.
The duplicate table html is replaced by some divs at the top of the window) + a single table (with 1 column) with one row to display the selection list and one row with action buttons (replacing the original lengthy text and links. Large terms do now no longer result in a corrupt display.
Many remains of older versions in the script are removed.
Notes:
This script serves only central/dataentry. Copies of diccionario.php in other folders are not touched yet. The translations for these scripts are also still present
Error processing was not present and this is still the case.

You can view, comment on, or merge this pull request online at:

https://github.com/ABCD-DEVCOM/ABCD2/pull/232

Commit Summary

afca554 Update select search term window

File Changes

(4 files)

M www/htdocs/central/dataentry/diccionario.php (281)
D www/htdocs/central/dataentry/ifepil.php (47)
D www/htdocs/central/dataentry/ifpro.php (184)
M www/htdocs/central/lang/00/admin.tab (3)

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

ABCD-DEVCOM / ABCD2

Update select search term window #232