search

ABCxFF / diepcustom

An open source diep.io custom private-server template
https://diepcustom.herokuapp.com/
GNU Affero General Public License v3.0
69 stars 60 forks source link

fix random crashing on first 0x00 packet #127

Closed ABCxFF closed 1 year ago

ABCxFF commented 1 year ago

Why:

No issue posted - though it could relate to #96

Summarize what's being changed (include any screenshots, code, or other media if available):

The issue was the fact that entities in view were checked to see if they were updated.Arena has a special case for being added to the view, and that case is before the "is updated?" check. This caused a possible scenario where arena was both created and updated in the same packet

Updates are sent before creations, so this caused an issue. Instead of swapping updates and creation, ended up putting the special case for arena compilation after the "is updated?" check is complete.

Confirm the following:

I have NOT tested these changes (by compiling, running, and playing) and have seen no unintended differences in gameplay

Nul-led commented 1 year ago

I was unable to replicate the crashes consistently :/

So i dont know if this fix works or not

Nul-led commented 1 year ago

merged after testing a bit more, it really does seem to fix the issue