search

ABCxFF / diepcustom

An open source diep.io custom private-server template
https://diepcustom.herokuapp.com/
GNU Affero General Public License v3.0
62 stars 60 forks source link

Inaccuracy in bullets emerging from barrel #48

Open biemster opened 1 year ago

biemster commented 1 year ago

What is inconsistent Bullets seem to emerge much more from the point where the barrel is connected to the tank, while in original they more clearly come from the end of the barrel. This is best noticed when traveling diagonal with respect to barrel direction. It's possible that in the original the bullets start out quite a bit quicker than their overall average speed, which might be missing here.

Expected behavior Bullets appear more coming from the tip of the barrel when moving sideways or diagonally wrt barrel direction.

Additional notes This issue is difficult to exactly quantify, but as a regular player this definitely "feels" off compared to the original. (I hope that is enough to warrant a ticket, otherwise please close.)

ABCxFF commented 1 year ago

Thank you - I'll test the spawn locations more precisely later this week and make fixes accordingly. Thanks for reporting this

biemster commented 1 year ago

Awesome, thanks. Absolutely great project btw, I'm going to browse the code and issues and see coming days if I can contribute somehow.

supahero1 commented 1 year ago

I'm pretty sure the inaccuracy is caused by the tank's velocity not being added to the newly created bullet's velocity @ABCxFF (or am I crazy or it's added reverse to what the tank's vel is??)

ABCxFF commented 1 year ago

@supahero1 unsure. When coding the whole bullet spawning system, I always remember using some makeshift code to make it "seem" right, so I wouldn't be surprised if it was off. That being said I am pretty sure that the tank's velocity is not added to the velocity of the newly created bullet (neither in real diep nor diepcustom), so it's probably something else.

Nonetheless, just fixed my entity position parser / recorder, so will be able to research this a bit more deeply now. Will keep you updated

SeaDubstep commented 1 year ago

I know how to fix it, first download Tampemonkey, then this script: https://greasyfork.org/en/scripts/411776-ren-minimap-viewport-ren-upgrades-predict-movement after this go into script edit, then near // @match ://diep.io press enter and create a new line, then add // @match ://diepcustom.herokuapp.com/ (between these messages there are stars (this sign *) after we do it go in diepcustom, and when you join server press N

ABCxFF commented 1 year ago

I know how to fix it, first download Tampemonkey, then this script: https://greasyfork.org/en/scripts/411776-ren-minimap-viewport-ren-upgrades-predict-movement after this go into script edit, then near // @match ://diep.io press enter and create a new line, then add // @match ://diepcustom.herokuapp.com/ (between these messages there are stars (this sign *) after we do it go in diepcustom, and when you join server press N

I think you are addressing something else - this issue has to do with something more internal.

Also, can confirm #48 now btw (was checking with parsers) - there definitely is an inconsistency. Still debugging