Feedback of the HTML code of your Tribute Page

[carmen-tm]

Well done, Abdellatif! I just had a look at this Tribute Page repository and looks great. To give you some feedback as I promised, I opened this "issue" here on your Github repository. Issues are used to do many things, for example, to keep track of small tasks, bugs, enhancements or any other requests. Here you have some documentation. As a developer, you are going to use them a lot in the future, so I thought it would be a good idea to communicate my feedback through one 🚀. You can reply to this message if you want to, and "close" this issue when you think your fixes are ready. I usually open issues in my own repositories of the things that I want to improve in the future, describing them, so I don't forget :)

So about the feedback:

• Good semantics! I see you were careful with the HTML tags you chose, well done. 🙂 A possible improvement (but not mandatory) could be to consider the h1 and p tags at the beginning of your code as content for a <header> tag. Here you can read some header documentation. The<main> tag would start just right after the <header>ends. Is up to you, your way is also valid, but I think that would be a nice semantic improvement.
• Indentation is very good, not perfect but almost!! 👏🏻. As advanced advice, I would suggest not giving so many empty lines between the tags (for example here, where you have the lines 14, 15 and 16 empty). There are no big rules about empty spaces (as we comented in the class, each person has a personal style of writing code and it's totally fine) but in general, I would say people use 0 or 1 empty line between tags. I sometimes use 1 empty line in places where I think they make my code looks more clear, so that's the idea. But my advice is to use no more than 1 empty line, in order to keep our code compact and not super long. 🙂
• Great that you were brave enough to link CSS style file. You will enjoy all the styles lessons very soon, and maybe you could try more things here, in future commits :)

Just a couple of small improvements I found:

• [ ] I saw a lonely closing </div> tag here in line 13 (here you can see the exact line on your code) that I think is a small error from old code or something, that you should remove.
• [ ] I found another small typo in line 37, in your link anchor (here in your code), in the opening tag there is an "a" that I think is an error too that you could clean.

And a final thing: I think the user story #4 of the exercise says:

User Story #4: Within the img-div element, I should see an img element with a corresponding id="image".

• [ ] I think your image tag is missing that id attribute 😉.

You can fix these 3 small things if you are ok with that, and close this issue when it's ready. Once again, well done!!

[ABDELLATIF-HAJJI]

Hi carmen Thank you so much professor I really benefit from your correction and I realised many mistakes I did I tried to correct them I appreciate your help

Thank you