ABRG-Models / morphologica

A library of supporting code for numerical modelling (JSON config, HDF5 data, Modern OpenGL visualization)
https://abrg-models.github.io/morphologica/
Apache License 2.0
255 stars 29 forks source link

put maybe_unused instead of constexpr #165

Closed fabien-colonnier closed 6 months ago

fabien-colonnier commented 6 months ago

Modify the default virtual function for key_callback_extra and mouse_button_callback_extra to avoid the unused arguments error in c++14

fabien-colonnier commented 6 months ago

I also checked the other header files to manage consitency in the repo, only BezCurve.h has also a similar pattern with the variable debug_bezcurve but the variable are used even when the parameter is set to false. So I didn't modify the file

sebjameswml commented 6 months ago

Thanks Fabien!