ABSESpy / ABSESpy

An Agent-based Social-ecological System python framework for coupling human-nature researches.
Apache License 2.0
40 stars 3 forks source link

docs: missing DOI and citation in `refs.bib` #36

Closed wang-boyu closed 7 months ago

wang-boyu commented 7 months ago

Hi, I'm reviewing your JOSS paper and found some missing info in your references. More specifically -

On a side note, it would be nice if you could format the references is a consistent way, either all in title case, or all in sentence case, but not a mix of both. For example,

Sentence case: Beckage, B., Moore, F. C., & Lacasse, K. (2022). Incorporating human behaviour into Earth system modelling. ...

Title Case: Beckage, B., Moore, F. C., & Lacasse, K. (2022). Incorporating Human Behaviour into Earth System Modelling. ...

But this is not strictly required; just something nice to have for your own consideration. It's not blocking the paper review.

jamesdamillington commented 7 months ago

On line 99 of the JOSS proof there is a reference to wang2022 that is missing (this may be the same reference @wang-boyu refers to in their second bullet point). Please add this reference.

SongshGeo commented 7 months ago

Thanks for the explanation by @jamesdamillington; yep, the reference to mesa-geo was not rendered because it lacked a bib item. It would be arrogant if I totally ignored mesa-geo but invited @wang-boyu to review this repo, LOL.

The behavior of the case-sensitive problem was because when exporting the .bib file, a 'keep case' option was selected.

Now everything is fixed in PR #38.