ABSphreak / readme-jokes

😄 Jokes for your GitHub READMEs
https://readme-jokes.vercel.app/api
MIT License
648 stars 119 forks source link

Randomization fix #18

Closed karmanya007 closed 3 years ago

karmanya007 commented 3 years ago
  1. Fixed, jokes not randomly generated after each GET request to /api.
  2. Added cache age options.
  3. Removed a reused joke in jokes.json
  4. Also fixed the index variable it's value can be greater than the jokes array.
vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/absphreak/readme-jokes/dm90dwguu
✅ Preview: https://readme-jokes-git-randomizationfix.absphreak.vercel.app

ABSphreak commented 3 years ago

Will fix that in a bit, it's gonna crash a lot of things 🤣