search

ABSphreak / readme-jokes

😄 Jokes for your GitHub READMEs
https://readme-jokes.vercel.app/api
MIT License
655 stars 121 forks source link

Added themes support #23

Closed DentFuse closed 4 years ago

DentFuse commented 4 years ago

I saw that the themes file was present but not used, so I added a theme query parameter. Also changed themes.js to themes.json.

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/absphreak/readme-jokes/dxxqfo2re
✅ Preview: https://readme-jokes-git-master.absphreak.vercel.app

ABSphreak commented 4 years ago

@DentFuse is it working on the deployment tho? Can you provide screenshot and a query that is working on these preview links?

DentFuse commented 4 years ago

Yup! It's working @ABSphreak. Here's the preview on the deployment. https://readme-jokes-dxxqfo2re.vercel.app/api?theme=halloween

ABSphreak commented 4 years ago

@DentFuse Awesome work man!