search

ABSphreak / readme-jokes

😄 Jokes for your GitHub READMEs
https://readme-jokes.vercel.app/api
MIT License
646 stars 119 forks source link

multiline jokes are just concatenated #47

Closed ntaraujo closed 2 years ago

ntaraujo commented 3 years ago

image

maybe an space :)

sumitkumarju commented 2 years ago

@ABSphreak Can I do it under hactoberfest?

ABSphreak commented 2 years ago

Sure @sumitkumarj, go ahead.

sumitkumarju commented 2 years ago

hey, @ABSphreak how to reproduce the issue locally?

ABSphreak commented 2 years ago

@sumitkumarju, I think the jokes that do not have a <br/> tag in them in the JSON file are causing problems. So, if you don't add <br/> tags in multi-line jokes - like question/answer type jokes, they are just concatenated together. So, for local reproduction of this bug, I would suggest you add a multiline joke and not add <br/> and see if you can fix it programmatically.

sumitkumarju commented 2 years ago

@ABSphreak Understood. But how to run the project locally? I see npm start not working.

ABSphreak commented 2 years ago

@sumitkumarju there is no npm start script, you have to use vercel-cli to run the project, you must have a vercel account.

Vercel is a hosting service, mostly used to host serverless functions and NextJS projects.

You can check out their guide on how to get started with the CLI or you can check this guide too.

Maybe I should add a contributing guide to the project. Thanks for pointing out.

sumitkumarju commented 2 years ago

hey @ABSphreak I am getting 502:BAD GATEWAY and this error on running vercel dev

Unhandled rejection: TypeError: helper.createServerWithHelpers is not a function at C:\Users\titan\AppData\Roaming\npm\node_modules\vercel\node_modules\@vercel\node\dist\launcher.js:89:37

ABSphreak commented 2 years ago

@sumitkumarju most likely a configuration problem with vercel-cli installation. Make sure you install it globally and run vercel in the project directory. It will likely ask for logging into your vercel account. Login using the web browser.

sumitkumarju commented 2 years ago

@ABSphreak Did everything as you mentioned. Still getting the error on hitting the /api end point after running vercel dev

image

ABSphreak commented 2 years ago

Node Version?

sumitkumarju commented 2 years ago

12.18.4

Node Version?

ABSphreak commented 2 years ago

Try with Node 14 once. Use node version switching methods like n or nvm.

SaiSridhar783 commented 2 years ago

Hey! I would like to try this

ABSphreak commented 2 years ago

Go ahead @SaiSridhar783, but try to run the project first.

SaiSridhar783 commented 2 years ago

@ABSphreak I have made PR. Kindly review it.