Image is shrinked on Github

[poblouin]

Summary

The image height is shrinked on Github (markdown) for some reason. I noticed it few days ago, not sure how long it's been like that.

System: Macbook Air M1 2020 Monterey 12.0.1 Firefox 94.0.2

How To Reproduce

Steps to reproduce the behavior:

Just look at the README of the repo, you can see the issue there. It's the same in my own README. I haven't try the HTML version, only the markdown.

Do someone have an idea of what is going on or noticed the same issue as I do? I never worked on this project, but I'll try to take some time to investigate and find a fix.

[ABSphreak]

Happens on Firefox and Mobile.

3 & #46.

[poblouin]

Ah thanks, I wasn't sure that #46 was related.

[poblouin]

@ABSphreak Forcing the width and height seems to fix the issue: https://github.com/poblouin/readme-jokes/pull/1. You can test using the Vercel URL from the build.

That's not enough though, we would need to dynamically adapt those values based on the content of the card. That's a start, but I don't think I am good enough at CSS + SVG to properly solve it 😅

[ABSphreak]

Closed in #68, I think.

[poblouin]

@ABSphreak The issue is still present, I still see it on Firefox when I look at the README of the repo.

[ABSphreak]

@poblouin would look into it